Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Backported fix for multiarch unit tests #9142

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Apr 17, 2024

backport of #9141
and also backport of #9137

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_0_X/master.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771e09/38893/summary.html
COMMIT: 63b889b
CMSSW: CMSSW_14_0_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9142/38893/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-rivet-list had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9142 was updated.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Apr 17, 2024

please test for CMSSW_14_0_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771e09/38912/summary.html
COMMIT: b547e45
CMSSW: CMSSW_14_0_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9142/38912/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771e09/38915/summary.html
COMMIT: b547e45
CMSSW: CMSSW_14_0_MULTIARCHS_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9142/38915/install.sh to create a dev area with all the needed externals and cmssw changes.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9142 was updated.

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_0_MULTIARCHS_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771e09/38923/summary.html
COMMIT: 8a73368
CMSSW: CMSSW_14_0_X_2024-04-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9142/38923/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771e09/38927/summary.html
COMMIT: 8a73368
CMSSW: CMSSW_14_0_MULTIARCHS_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9142/38927/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 636 lines from the logs
  • Reco comparison results: 69752 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318804
  • DQMHistoTests: Total failures: 142989
  • DQMHistoTests: Total nulls: 269
  • DQMHistoTests: Total successes: 3175526
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.688000000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): -0.854 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 140.043,... ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.086 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.303 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.225 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.533 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -4.839 KiB SiStrip/MechanicalView
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 16 / 46 workflows

@smuzaffar
Copy link
Contributor Author

+externals
this fixes the rivet tests for multiarch build.

@smuzaffar smuzaffar merged commit 778f157 into IB/CMSSW_14_0_X/master Apr 19, 2024
16 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants